Unconventional sunrise sunset times #830
Conversation
for more information, see https://pre-commit.ci
| assert_expected_color_temp(state) | ||
|
|
||
|
|
||
| async def test_unconventional_sun_events(hass): |
There was a problem hiding this comment.
This test seems to be defined twice
|
I'm confused. So you forked over my existing PR at #535, then you modified it, then you submitted a new pull request for us asking to merge this. But more importantly, why is your PR showing that I committed here two days ago? Is this a github bug? |
This is standard behavior of Git and not related to GitHub. @b-rad15 rebased your branch, which created copies of your original commits. Git automatically assigned you as original author of these commits, and @b-rad15 as the committer. He ran the rebase operation two days ago (from the time of your post), hence the date. So this is basically Git's way of crediting your past work to you, even when copied by someone else. |
4 participants
Rebased this branch #535 addressing #105 given the updates since it was created. It works fine adding it to my homeassistant integration but I can't get the tests to run correctly (Triggering pytest-socket somehow and causing every one to instantly stop, not an actual test failure) so it would help if someone who has had success running those before could make sure something else wasn't unintentionally broken.