Proposed v2.0.2 rewrite using google-spreadsheet@3.1.15#31
Open
johnbeech wants to merge 23 commits into
Open
Conversation
Maintenance: Create PR Check Workflow from Template
Software: npm package-lock rebuild
* Add end-to-end test for an actual spreadsheet * Rewrite of helper.js to use new google-spreadsheet module API * Implement correct search behaviour for mapping data * Fix test to work on CI environment * Remove work in progress console.log * Update README and CHANGELOG * Add note about fixed security vulnerabilities * Add test-example.js to check equivalent code in README
johnbeech
changed the title
johnbeech
changed the title
|
@bassarisse I tested this updated code from @johnbeech and it seems to work great. In fact for my basic usage I was able to simply load his updated version without any code changes to my actual implementation code. I'd definitely recommend this update since the Google Spreadsheet module that is referenced has now passed the date that it was said to have been deprecated. |
|
Any reason why this shouldn't be merged? This library is kinda useless without these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've raised an issue here: #32 to advertise an updated version of the tool as a potential candidate to merge in the future.
Proposed change log:
2.0.2
Changes
2.0.1
Changes
allWorksheets: trueand added additional test2.0.0
New
Changes
npm audit