Modernize entity lifecycle and handle unavailable humidity sensorsUpdate binary_sensor.py - #58
Open
Corsw wants to merge 1 commit into
Open
Modernize entity lifecycle and handle unavailable humidity sensorsUpdate binary_sensor.py#58Corsw wants to merge 1 commit into
Corsw wants to merge 1 commit into
Conversation
Modernize entity lifecycle and startup handling
Author
|
Hi Bas, You mentioned previously that someone would be welcome to take over and I use this integration myself and have prepared a draft pull request that modernizes the entity lifecycle and fixes the startup handling while preserving the existing behaviour. I would be willing to maintain the integration going forward. Would you be open to reviewing the pull request and discussing either |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request modernizes the binary sensor entity while preserving the
existing periodic humidity-rise detection behaviour.
Changes
Behaviour preserved
The integration still samples the source sensor periodically and compares the
current humidity with the lowest sample in the configured sample window. It
has not been converted to state-change-based sampling.
Testing
Tested on my Home Assistant installation with:
The startup warnings from issue #30 no longer occur for normal temporary
unknown or unavailable states.