Reduce the number of Bastion dependencies#58
Open
KPull wants to merge 8 commits intobastion-dev:developfrom
Open
Reduce the number of Bastion dependencies#58KPull wants to merge 8 commits intobastion-dev:developfrom
KPull wants to merge 8 commits intobastion-dev:developfrom
Conversation
Member
Author
|
I talked with @FrelliBB about this who suggested we split up the optional modules into their own Maven modules. This is actually the suggested way of doing things, with the advice written on the same page which explains 'Optional Dependencies': https://maven.apache.org/guides/introduction/introduction-to-optional-and-excludes-dependencies.html We're going to try out how the whole structure will look like once we split everything up into dependencies. |
Fixing tests.
method does not take an entity. Updated the RequestExecutor to remove dependency on Unirest and use the plain HTTP client.
Moved assertJ dependency to test scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've cleaned up the code so that we can mark the following two dependencies as optional:
If the user wants to use these features with Bastion, they need to add them to their own POM file first (they're not pulled automatically with Bastion).
This fixes: #57.