Skip to content

Conversation

@vdemestral
Copy link
Collaborator

I add the possibility of computing the clamped Pockels tensors into the VibroMixing class.

@cla-bot
Copy link

cla-bot bot commented Jun 13, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Virginie de Mestral.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@vdemestral vdemestral requested a review from bastonero June 13, 2024 09:29
@cla-bot
Copy link

cla-bot bot commented Jun 13, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Virginie de Mestral.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

1 similar comment
@cla-bot
Copy link

cla-bot bot commented Jun 13, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Virginie de Mestral.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link
Owner

@bastonero bastonero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is awesome, thanks @vdemestral ! Just some minor changes!

@aiida-cla-bot
Copy link
Contributor

aiida-cla-bot bot commented Nov 29, 2024

All contributors have accepted the CLA ✅


You might need to click the "Update/Rebase branch" button to update the pull request and rerun the GitHub actions to pass the CLA check.
Posted by the CLA Assistant Lite bot.

@vdemestral
Copy link
Collaborator Author

I have read the CLA Document and I hereby accept the CLA

aiida-cla-bot bot added a commit that referenced this pull request Jan 9, 2025
@bastonero
Copy link
Owner

recheck

@codecov
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 70.21277% with 14 lines in your changes missing coverage. Please review.

Project coverage is 86.45%. Comparing base (81367a0) to head (50b5a34).

Files with missing lines Patch % Lines
src/aiida_vibroscopy/data/vibro_mixin.py 14.28% 12 Missing ⚠️
src/aiida_vibroscopy/calculations/spectra_utils.py 93.93% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
- Coverage   86.77%   86.45%   -0.32%     
==========================================
  Files          34       34              
  Lines        2502     2548      +46     
==========================================
+ Hits         2171     2203      +32     
- Misses        331      345      +14     
Flag Coverage Δ
pytests 86.45% <70.21%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vdemestral
Copy link
Collaborator Author

I have read the CLA Document and I hereby accept the CLA

@bastonero bastonero merged commit a4512de into bastonero:main Mar 6, 2025
3 of 5 checks passed
@aiida-cla-bot aiida-cla-bot bot locked and limited conversation to collaborators Mar 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants