Properties: reduce mesh for phonon mesh interpolation
#98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of 1000 for mesh interpolation is extreme and unnecessary. Phonopy defaults it to 100, which corresponds already to very large cells of about 50'000 atoms. We therefore choose 300, which is a very reasonable value and it is still feasible to run on common laptops.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
=======================================
Coverage 86.46% 86.46%
=======================================
Files 34 34
Lines 2549 2549
=======================================
Hits 2204 2204
Misses 345 345
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of 1000 for mesh interpolation is extreme and unnecessary.
Phonopy defaults it to 100, which corresponds already to very large
cells of about 50'000 atoms. We therefore choose 300, which is a
very reasonable value and it is still feasible to run on common laptops.