WIP: go/proto: Do not assume the repo_name being "io_bazel_rules_go" #2172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delay initializating the defaultProtoCompilers/defaultGrpcProtoCompilers until there is a valid module to apparent name mapping. Generate the proto/grpc compiler label using the apparent name mapping and fallback to io_bazel_rules_go if none exist.
zecke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delay initializating the defaultProtoCompilers/defaultGrpcProtoCompilers until there is a valid module to apparent name mapping.
Generate the proto/grpc compiler label using the apparent name mapping and fallback to io_bazel_rules_go if none exist.
What type of PR is this?
What package or component does this PR mostly affect?
What does this PR do? Why is it needed?
Makes running gazelle with a proto and
repo_name = "rules_go"work.Which issues(s) does this PR fix?
Fixes #
Other notes for review