-
-
Notifications
You must be signed in to change notification settings - Fork 116
feat: Enable some path-mapping support in common rules #1217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
f254157 to
b18b770
Compare
|
b18b770 to
5b5ba57
Compare
| # Sandboxing for this action is wasteful since there is a 1:1 mapping of input file/directory to | ||
| # output file/directory so little room for non-hermetic inputs to sneak in to the execution. | ||
| "no-sandbox": "1", | ||
| "supports-path-mapping": "1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With sandboxing disabled path mapping will only work with remote execution. Is skipping the sandbox for these actions really worth it? With so few inputs there should be very little overhead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. That's a good point. I don't think disabling sandbox is better than avoiding rerunning these actions when changing config...

No description provided.