Configure AR and STRIP tools for meson#1302
Open
mering wants to merge 3 commits intobazel-contrib:mainfrom
Open
Configure AR and STRIP tools for meson#1302mering wants to merge 3 commits intobazel-contrib:mainfrom
mering wants to merge 3 commits intobazel-contrib:mainfrom
Conversation
Draft
mering
force-pushed
the
meson-tools
branch
5 times, most recently
from
4163e1d to
95a7883
Compare
Member
|
This doesn't work on macOS from the look of things - commonly libraries don't build with AR=libtool on macos so that is probably the issue. Not sure what the correct fix is though |
If an AR var is not exported, meson will use static linker from the host
Contributor
Author
Contributor
Author
|
@fmeum could you maybe PTAL? Thanks! |
fmeum
reviewed
Feb 14, 2026
Member
fmeum
left a comment
fmeum
left a comment
There was a problem hiding this comment.
This looks good to me, but it's been years since I last dealt with rules_foreign_cc. I would prefer one of the maintainers to approve and merge.
Contributor
Author
|
@cerisier could you maybe take a look? |
Contributor
|
@cerisier I am also keen to stop having to patch this on my local |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required to fix
libdav1din #1295.Closes #1447