fix sysroot for make and pkgconfig built tools#1356
Merged
jsharpe merged 2 commits intobazel-contrib:mainfrom Feb 27, 2025
Merged
fix sysroot for make and pkgconfig built tools#1356jsharpe merged 2 commits intobazel-contrib:mainfrom
jsharpe merged 2 commits intobazel-contrib:mainfrom
Conversation
jsun-splunk
force-pushed
the
jsun-fix-sysroot
branch
2 times, most recently
from
39d6c8a to
82ec366
Compare
sysroot can be specified with as --sysroot=<meow> or --sysroot <meow>. This fix allows for the latter use case as well.
jsun-splunk
force-pushed
the
jsun-fix-sysroot
branch
from
82ec366 to
515d0dd
Compare
jsun-splunk
changed the title
jsharpe
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sysroot can be specified with as
--sysroot=<meow>or--sysroot <meow>. This fix allows for the latter use case as well.