feat: add MSBuild rule to build MSBuild projects.#1443
Open
jsun-splunk wants to merge 2 commits intobazel-contrib:mainfrom
Open
feat: add MSBuild rule to build MSBuild projects.#1443jsun-splunk wants to merge 2 commits intobazel-contrib:mainfrom
jsun-splunk wants to merge 2 commits intobazel-contrib:mainfrom
Conversation
6dbc50d to
cd48691
Compare
cd48691 to
f2c0495
Compare
matt-sm
reviewed
Nov 4, 2025
matt-sm
reviewed
Nov 13, 2025
d29e8e6 to
511adb0
Compare
matt-sm
reviewed
Nov 20, 2025
matt-sm
reviewed
Nov 20, 2025
matt-sm
reviewed
Nov 20, 2025
matt-sm
reviewed
Nov 21, 2025
Contributor
|
I'm trying to picture how deps would work eg. msbuild with dep for rfcc/cc_library |
Contributor
Author
wouldn't it be the same as other rules? i.e what you declare in |
511adb0 to
99bbec2
Compare
Contributor
I am thinking the other way - if msbuild had a dep on another ccinfo |
jsun-splunk
commented
Dec 2, 2025
99bbec2 to
f423dba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to add a rule to build MSBuild project from bazel. This rule only supports
MSBuild.exefrom MSVC.dotnet msbuildis not supported.MSBuild, aka Microsoft Build Engine is a platform for building applications. This engine provides an XML schema for a project file that controls how the build platform processes and builds software.
There are no source code to build from for MSBuild. There are also no prebuilt binaries that is available. Therefore, this rule is only availabe for pre-installed toolchain. This usually involves installing MSBuild along side MSVC.
MSBuild generates compile and link flags from project configuration and solution files. I have not been able to find a definitve way to override that so we can applied only the bazel generated flags. As a compromised, the generated bazel flags from cc_toolchain are added to a
msbuild.propsfiles and passed to MSBuild via the-p:ForceImportAfterCppTargetsproperty. This at the minimum confirms bazel flags are applied.