Skip to content

Don't symlink contents of directory recursively #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhanglin-zhou wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −4
Open

Don't symlink contents of directory recursively #1454

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1383036
Don't symlink contents of directory recursively
zhanglin-zhou Jan 3, 2026
a85ccb8
Merge branch 'main' into fix_recursive_symlink_contents_to_dir
zhanglin-zhou Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions foreign_cc/private/framework.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,8 +784,8 @@ def _list(item):

def _copy_deps_and_tools(files):
lines = []
lines += _symlink_contents_to_dir("lib", files.libs)
lines += _symlink_contents_to_dir("include", files.headers + files.include_dirs)
lines += _symlink_contents_to_dir("lib", files.libs, False)
lines += _symlink_contents_to_dir("include", files.headers + files.include_dirs, False)

if files.tools_files:
lines.append("##mkdirs## $$EXT_BUILD_DEPS$$/bin")
Expand All @@ -807,7 +807,7 @@ def _copy_deps_and_tools(files):

return lines

def _symlink_contents_to_dir(dir_name, files_list):
def _symlink_contents_to_dir(dir_name, files_list, replace_in_files):
# It is possible that some duplicate libraries will be passed as inputs
# to cmake_external or configure_make. Filter duplicates out here.
files_list = collections.uniq(files_list)
Expand All @@ -819,7 +819,7 @@ def _symlink_contents_to_dir(dir_name, files_list):
path = _file_path(file).strip()
if path:
lines.append("##symlink_contents_to_dir## \
$$EXT_BUILD_ROOT$$/{} $$EXT_BUILD_DEPS$$/{} True".format(path, dir_name))
$$EXT_BUILD_ROOT$$/{} $$EXT_BUILD_DEPS$$/{} {}".format(path, dir_name, replace_in_files))

return lines

Expand Down