Skip to content

pkgconfig: use the -std=gnu90 flag to compile #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
06393993 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

pkgconfig: use the -std=gnu90 flag to compile #1458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion foreign_cc/built_tools/pkgconfig_build.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def _pkgconfig_tool_impl(ctx):
frozen_arflags = flags_info.cxx_linker_static

cc_path = tools_info.cc
cflags = flags_info.cc + ["-Wno-int-conversion"] # Fix building with clang 15+
cflags = flags_info.cc + ["-Wno-int-conversion", "-std=gnu90"] # Fix building with clang 15+
sysroot_cflags = extract_sysroot_flags(cflags)
non_sysroot_cflags = extract_non_sysroot_flags(cflags)

Expand Down