Merged
Conversation
fmeum
approved these changes
Feb 6, 2026
This was referenced Feb 6, 2026
novas0x2a
added a commit
that referenced
this pull request
Feb 20, 2026
In #1459, `extra_toolchain` was changed from a string to a Label. This was necessary (it's no longer safe to pass labels as strings in the post-bzlmod world) but it created a problem: the ability to do ``` cmake_variant(toolchain=select({"A": "footoolchain", "B": ""})) ``` Kind of worked before, and no longer does (since "" is not a valid label). This change makes it so you can pass None instead of "" and it will do roughly what "" did.
novas0x2a
added a commit
that referenced
this pull request
Feb 20, 2026
In #1459, `extra_toolchain` was changed from a string to a Label. This was necessary (it's no longer safe to pass labels as strings in the post-bzlmod world) but it created a problem: the ability to do ``` cmake_variant(toolchain=select({"A": "footoolchain", "B": ""})) ``` Kind of worked before, and no longer does (since "" is not a valid label). This change makes it so you can pass None instead of "" and it will do roughly what "" did.
Merged
novas0x2a
added a commit
that referenced
this pull request
Feb 20, 2026
In #1459, `extra_toolchain` was changed from a string to a Label. This was necessary (it's no longer safe to pass labels as strings in the post-bzlmod world) but it created a problem: the ability to do ``` cmake_variant(toolchain=select({"A": "footoolchain", "B": ""})) ``` kind of worked before, and no longer does (since "" is not a valid label). This change makes it so you can pass None instead of "" and it will do roughly what "" did.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think we have a CI build that accurately represents the failure here, but this appears to work locally for me with both:
build --enable_bzlmod --noenable_workspace //toolchains/private:pkgconfig_toolbuild --noenable_bzlmod --enable_workspace //toolchains/private:pkgconfig_toolHopefully: