Let the user overrule CMAKE_SYSTEM_NAME#1461
Open
NEOatNHNG wants to merge 1 commit intobazel-contrib:mainfrom
Open
Let the user overrule CMAKE_SYSTEM_NAME#1461NEOatNHNG wants to merge 1 commit intobazel-contrib:mainfrom
NEOatNHNG wants to merge 1 commit intobazel-contrib:mainfrom
Conversation
CMAKE_SYSTEM_NAME and related variables can only hold a single value. It makes no sense to combine the user-provided value with the default. We should just replace the default value with the one from the user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMAKE_SYSTEM_NAME and related variables can only hold a single value. It makes no sense to combine the user-provided value with the default. We should just replace the default value with the one from the user.