Conversation
We were previously only creating them for data_dirs / TreeArtifacts, but being able to pull out individual files is helpful too.
These test functions are designed to: 1. Actually execute the build systems in question; previously, there were no build system tests in the base repo (just in examples) 2. Export various layers of variable (environment, cmake cache vars, etc) into files for testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These test functions are designed to:
AI disclosure: AI was used on this, largely to stamp out initial copies of the env_tests for each of the build systems and look for bugs. I stress that I (and not the bot) am ultimately responsible for the code.