Skip to content

Fix variant toolchains #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
novas0x2a merged 1 commit into from
Feb 20, 2026
+5 −2
Merged

Fix variant toolchains #1466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions foreign_cc/private/transitions.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@ load("@rules_cc//cc:defs.bzl", "CcInfo")
load("//foreign_cc:providers.bzl", "ForeignCcDepsInfo")

def _extra_toolchains_transition_impl(settings, attrs):
return {"//command_line_option:extra_toolchains": [attrs.extra_toolchain] + settings["//command_line_option:extra_toolchains"]}
t = getattr(attrs, "extra_toolchain", None)
if not t:
return {}

return {"//command_line_option:extra_toolchains": [t] + settings["//command_line_option:extra_toolchains"]}

_extra_toolchains_transition = transition(
implementation = _extra_toolchains_transition_impl,
Expand All @@ -29,7 +33,6 @@ extra_toolchains_transitioned_foreign_cc_target = rule(
# This attr is singular to make it selectable when used for add make toolchain variant.
"extra_toolchain": attr.label(
doc = "Additional toolchain to consider. Note, this is singular.",
mandatory = True,
),
"target": attr.label(
doc = "The target to build after considering the extra toolchains",
Expand Down