Skip to content

Remove transition of crane & jq to target platforms #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lionelfleury wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove transition of crane & jq to target platforms #794

lionelfleury wants to merge 2 commits into from
+2 −19

Conversation

@lionelfleury
Copy link
Contributor

@lionelfleury lionelfleury commented Apr 25, 2025 •
edited
Loading

  • these binaries are run on exec platform

@lionelfleury lionelfleury force-pushed the fix/transition-to-target branch from 519b126 to aa72709 Compare April 25, 2025 10:50
@addisonjones3
Copy link

addisonjones3 commented Sep 3, 2025

+1 would love to see this merged. It's becoming a challenge to do cross-platform Linux builds on macOS with the current transition.

@lionelfleury lionelfleury force-pushed the fix/transition-to-target branch from aa72709 to 84f87d1 Compare October 6, 2025 09:58
@lionelfleury lionelfleury marked this pull request as ready for review October 6, 2025 10:00
@aspect-workflows
Copy link

aspect-workflows bot commented Oct 6, 2025 •
edited
Loading

Test

⚠️ Buildkite build #167 failed.

//docs:push.extract failed to build

in src attribute of starlark_doc_extract rule //docs:push.extract: at
/mnt/ephemeral/workdir/bazel-contrib/rules_oci/oci/defs.bzl:18:6: initialization of module
'oci/private/push.bzl' failed. Since this rule was created by the macro 'stardoc_with_diff_test', the error
might have been caused by the macro implementation

//docs:image_index.extract failed to build

in src attribute of starlark_doc_extract rule //docs:image_index.extract: at
/mnt/ephemeral/workdir/bazel-contrib/rules_oci/oci/defs.bzl:18:6: initialization of module
'oci/private/push.bzl' failed. Since this rule was created by the macro 'stardoc_with_diff_test', the error
might have been caused by the macro implementation

//docs:image.extract failed to build

in src attribute of starlark_doc_extract rule //docs:image.extract: at
/mnt/ephemeral/workdir/bazel-contrib/rules_oci/oci/defs.bzl:18:6: initialization of module
'oci/private/push.bzl' failed. Since this rule was created by the macro 'stardoc_with_diff_test', the error
might have been caused by the macro implementation

@@empty_image//:empty_image failed to build

error loading package '@@empty_image//': at /mnt/ephemeral/workdir/bazel-contrib/rules_oci/oci/defs.bzl:18:6:
initialization of module 'oci/private/push.bzl' failed

error loading package '@@empty_image//': at /mnt/ephemeral/workdir/bazel-contrib/rules_oci/oci/defs.bzl:18:6:
initialization of module 'oci/private/push.bzl' failed

2 other actions failed to build.

💡 To reproduce the build failures, run

bazel build //docs:push.extract //docs:image_index.extract //docs:image.extract @@empty_image//:empty_image

@thesayyn
Copy link
Collaborator

thesayyn commented Oct 15, 2025

Do you mind rebasing here?

@thesayyn thesayyn mentioned this pull request Oct 15, 2025
Closed
@brianmcarey
Copy link
Contributor

brianmcarey commented Oct 21, 2025 •
edited
Loading

+1 - this would be great to see added. If I can help in anyway to get this in let me know.

@enp0s3
Copy link

enp0s3 commented Oct 21, 2025

+1 waiting for it to get in

@lionelfleury
Remove transition of crane & jq to target platforms
04707bd 
- these binaries are run on an exec platform
@lionelfleury
cfg
0d64588
@lionelfleury lionelfleury force-pushed the fix/transition-to-target branch from 84f87d1 to 0d64588 Compare November 5, 2025 12:20
@lionelfleury
Copy link
Contributor Author

lionelfleury commented Nov 5, 2025

rebased.

@brianmcarey brianmcarey mentioned this pull request Nov 27, 2025
Merged
thesayyn pushed a commit that referenced this pull request Dec 2, 2025
@brianmcarey @lionelfleury
fix: multiarch image builds by using host architecture for jq and cra…
95689ff 
…ne (#869)

This PR builds on #794 to fix the failing CI jobs. 

Multiarch image builds can fail due to the target architecture for jq
and crane. For example if you are building an arm64 image on a x86
machine a failure similar to this will occur:

```
line 52: ../jq_linux_arm64/jq: cannot execute binary file: Exec format error
```
As jq and crane run on the host building the images the host
architecture should be used rather than the target arch.

---------

Signed-off-by: Brian Carey <[email protected]>
Co-authored-by: Lionel Fleury <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lionelfleury @addisonjones3 @thesayyn @brianmcarey @enp0s3