Skip to content

revert(pypi): use Python for marker eval and METADATA parsing #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 28, 2025
Merged

revert(pypi): use Python for marker eval and METADATA parsing #2834

merged 11 commits into from
Apr 28, 2025

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Apr 28, 2025 •
edited
Loading

Summary:

Fixes #2830

aignas added 2 commits April 28, 2025 19:10
@aignas
revert(pypi): use Python for marker eval and METADATA parsing
0b69149 
Summary:
- Revert to using Python for marker evaluation during parsing of
  requirements (partial revert of bazel-contrib#2692).
- Use Python to parse whl METADATA.

Fixes bazel-contrib#2830
@aignas
wip
b258eb9
@aignas aignas changed the title revert(pypi): start using legacy paths revert(pypi): use Python for marker eval and METADATA parsing Apr 28, 2025
@aignas aignas marked this pull request as ready for review April 28, 2025 11:18
@aignas aignas requested review from rickeylev and groodt as code owners April 28, 2025 11:18
@aignas aignas mentioned this pull request Apr 28, 2025
Closed
@rickeylev rickeylev added this pull request to the merge queue Apr 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 28, 2025
@rickeylev rickeylev added this pull request to the merge queue Apr 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 28, 2025
@rickeylev rickeylev added this pull request to the merge queue Apr 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 28, 2025
@rickeylev rickeylev added this pull request to the merge queue Apr 28, 2025
Merged via the queue into bazel-contrib:main with commit 5b9d545 Apr 28, 2025
3 checks passed
aignas added a commit that referenced this pull request Apr 29, 2025
@aignas
revert(pypi): use Python for marker eval and METADATA parsing (#2834)
4dc0665 
Summary:
- Revert to using Python for marker evaluation during parsing of
  requirements (partial revert of #2692).
- Use Python to parse whl METADATA.
- Bugfix the new simpler algorithm and add a new unit test.

Fixes #2830

(cherry picked from commit 5b9d545)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickeylev rickeylev rickeylev approved these changes

@groodt groodt Awaiting requested review from groodt groodt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revert the starlark PEP508 evalutaion
2 participants
@aignas @rickeylev