[metadata] extensions: define package_metadata_override rule
#106
Conversation
Sadly, I had to reimplement `package_group` in starlark for this to allow referencing other repositories `native `package_group` prohibits creating patterns starting with `@`).
| PackageMetadataInfo, | ||
| ], | ||
| ), | ||
| "packages": attr.label( |
There was a problem hiding this comment.
I think we need this on target also.
There was a problem hiding this comment.
We already support //foo/... //foo (all targets in the package) and //foo:bar (for the exact target) (+ their @somethingsomething equivalents)
Renaming to targets SGTM
There was a problem hiding this comment.
Yes. Let's rename this early to make it clear.
|
I'm not convinced of this yet. I would really like to review it within a large example of how it plays out. |
aiuto
left a comment
aiuto
left a comment
There was a problem hiding this comment.
Let's not do this right before bazelcon. We should really check this in the context of examples.
why? It's completely separate and doesn't interfere with any existing API and it's the first change that comes with actual tests :) I don't see how this could be a problem |
| A dict from a dummy label to the parsed configuration. | ||
|
|
||
| Key: a label in the repository of the target pattern. Only `Label.repo_name` is | ||
| used. Does not need to extist. |
Sadly, I had to reimplement
package_groupin starlark for this to allow referencing other repositories (nativepackage_groupprohibits creating patterns starting with@).