[metadata] Implement encoder for purls (part 1) #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it easier for users (esp. bzlmod extensions integrating with package managers) to generate `package_metadata` targets.
Instead of having to write `purl = "pkg:bazel/{}@{}".format(module_name(), module_version()) if module_version() else "pkg:bazel/{}".format(module_name())` everywhere to construct a `purl`, users can now write `purl = purl.bazel(module_name(), module_version())` and it'll automatically do the right thing.
Co-authored-by: Yannic <[email protected]>
Collaborator
Author
|
@Yannic By just writing the strings I eliminated the need for the json encoding. Now it passes in bazel7 and 8. |
tonyaiuto
reviewed
Jul 18, 2025
| "//purl/...", | ||
| ]) | ||
|
|
||
| encode_byte = { |
There was a problem hiding this comment.
I might argue that this should be a list, indexed by byte
|
Friengly ping |
Collaborator
Author
|
Friendly ping |
Collaborator
Author
|
Anyone there? |
Collaborator
would it be ok if I reviewed it early next week? |
|
Yes. You might also look at Yannic's version. That was failing on Bazel7 because of the difference in the way Bazel 7 and 8 handle JSON. This PR makes it work by not wrapping the test data as JSON. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier for users (esp. bzlmod extensions integrating with package managers) to generate package_metadata targets.
Based on #14