cc_binary: support .dSYM generation #402
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjivos
requested review from
aaronsky,
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
keith
reviewed
Apr 17, 2025
There was a problem hiding this comment.
Can you add a test similar to
apple_support/test/linking_tests.bzl
Lines 217 to 226 in af8d93a
nit: please run pre-commit to format the code with clang-format
I think the test failure here is related to this change, not 100% sure
Add support for generating a .dSYM file if this is requested using `--apple_generate_dsym`. This change contains the following patches: * Add `-fdebug-prefix-map` and `-oso_prefix` compiler and linker flags as in more recent Xcode versions (16E140) it would cause sandbox paths leaking into the linked binaries. * Add `DSYM_HINT` flags to be picked up by `wrapped_clang` to generate .dSYM bundles on request. * In `wrapped_clang.cc` make sure the linked binary is stripped after generating the .dSYM bundle first to make the .dSYM bundle contain useful information. Adopts recent changes in bazel to support .dSYM files (as part of fixing bazelbuild/bazel#16893).
benjivos
force-pushed
the
feat/support_dsym
branch
from
2c041da to
b800f37
Compare
|
i think this looks good but we need to wait for the bazel change to make sure this is the right path |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for generating a .dSYM file if this is requested using
--apple_generate_dsym. This change contains the following patches:DSYM_HINTflags to be picked up bywrapped_clangto generate .dSYM bundles on request.wrapped_clang.ccmake sure the linked binary is stripped after generating the .dSYM bundle first to make the .dSYM bundle contain useful information.Adopts changes in bazel to support .dSYM files (as part of fixing bazelbuild/bazel#16893).