Skip to content

[email protected] #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

publish-to-bcr-bot[bot]
Copy link
Contributor

This was referenced Dec 14, 2023
@alexeagle alexeagle added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Dec 14, 2023
@alexeagle
Copy link
Contributor

Test failure FileNotFoundError: [Errno 2] No such file or directory: '/var/lib/buildkite-agent/builds/bk-docker-lh36/bazel-org-repo-root/output/rules_python_poetry-0.1.0/e2e/bzlmod/.bazelrc'

looks like your repo needs a file like https://github.com/bazel-contrib/rules-template/blob/main/e2e/smoke/.bazelrc

@AndrewGuenther
Copy link

@alexeagle Is there any way I can run these presubmit checks on my own to minimize round trips here?

@hofbi
Copy link
Contributor

hofbi commented Feb 21, 2024

@AndrewGuenther Would be super happy to seem that available as bazel module. Any chance you can pick this up again?

@AndrewGuenther
Copy link

@hofbi I'm not particularly inclined to pick this back up any time soon. The project is still usable via bzlmod with an override

I've encountered pretty significant problems with bzlmod as well as issues trying to get listed on the registry here. As such, my organization is holding off on bzlmod generally until support is more mature.

@fmeum
Copy link
Contributor

fmeum commented Feb 21, 2024

I've encountered pretty significant problems with bzlmod as well as issues trying to get listed on the registry here. As such, my organization is holding off on bzlmod generally until support is more mature.

@AndrewGuenther It would be highly appreciated if you could share details about the issues you encountered, especially regarding this registry.

@AndrewGuenther
Copy link

@fmeum We ran into a lot of bugs in rules packages surrounding bzlmod behaviors. Especially rules_python where I think we encountered at least 5 different blocking issues. Those issues have since been resolved, but considering we ran into those issues in the first steps of the migration, it was enough for us to put off the migration til probably June at the earliest.

As for the registry, I got quite a bit of help from folks on the Bazel Slack, but at the end of the day I tried three times to submit my package and ran into different undocumented requirements for submitting each time before I finally gave up. I don't see it as a package registry's responsibility to test my packages or approve my releases, that's my responsibility as a package owner. I know my package works, quite a few people are using it, why so many hoops to get it on the registry?

@fmeum
Copy link
Contributor

fmeum commented Feb 22, 2024

The processes are still more manual than they could be, just because automation is hard to get right in this setting (especially considering security implications).

It's intentional that the very first module version is reviewed manually, simply because Bzlmod as a whole is quite new and there are problems reviewers can catch that aren't easy to encode in a list of best practices.

If you don't want any kind of testing, you can disable it, but there is a reason for encouraging test setup for modules in BCR: This allows us to run meaningful downstream tests for new Bazel versions, thus catching bugs and regressions earlier. This has been a bit of an issue in the past and, hopefully, the one-time setup cost is made up for by better stability guarantees.

Happy to help if you want to give it another try. Please also point to areas in which documentation is lacking.

@alexeagle
Copy link
Contributor

@meteorcloudy has been working recently to let you run these presubmits locally.

Could we close this one since it's been over a year? Or are you still working on it?

@meteorcloudy
Copy link
Member

Yes, instructions is here: https://github.com/bazelbuild/bazel-central-registry/blob/main/docs/README.md#reproduce-presubmit-builds-locally

You can rebase to HEAD and run the command to reproduce locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants