Skip to content

Add yams 5.1.0 #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Add yams 5.1.0 #1680

merged 3 commits into from
Apr 8, 2024

Conversation

jpsim
Copy link
Contributor

@jpsim jpsim commented Mar 23, 2024

@jpsim
Copy link
Contributor Author

jpsim commented Mar 23, 2024

I guess I need a maintainer to approve this:

BcrValidationResult.NEED_BCR_MAINTAINER_REVIEW: The presubmit.yml file of [email protected] doesn't match its previous version [email protected], the following presubmit.yml file change should be reviewed by a BCR maintainer.
    --- modules/yams/5.0.6/presubmit.yml
    +++ modules/yams/5.1.0/presubmit.yml
    @@ -9,7 +9,7 @@
         platform: ubuntu2004
         environment:
           CC: "clang"
    -      SWIFT_VERSION: "5.8.1"
    +      SWIFT_VERSION: "5.10"
           SWIFT_HOME: "$HOME/swift-$SWIFT_VERSION"
           PATH: "$PATH:$SWIFT_HOME/usr/bin"
         shell_commands: *shell_commands

@brentleyjones
Copy link
Contributor

Btw you submitted here as well: #1679

@jpsim
Copy link
Contributor Author

jpsim commented Mar 24, 2024

Btw you submitted here as well: #1679

Ah I forgot this repo has the bot enabled. Some of my other modules don’t have that integration working.

@jpsim
Copy link
Contributor Author

jpsim commented Apr 8, 2024

Can a BCR maintainer please trigger CI? Maybe @brentleyjones ?

brentleyjones
brentleyjones previously approved these changes Apr 8, 2024
@bazel-io bazel-io dismissed brentleyjones’s stale review April 8, 2024 13:53

Require module maintainers' approval for newly pushed changes.

@jpsim
Copy link
Contributor Author

jpsim commented Apr 8, 2024

I think I need to make more changes upstream for Bazel 7.x support. For now I've updated the presubmit file to use Bazel 6.x.

@jpsim
Copy link
Contributor Author

jpsim commented Apr 8, 2024

This needs another maintainer approval to run (sorry to bug @brentleyjones, but that seems to be the intended process here?)

@fmeum fmeum enabled auto-merge (squash) April 8, 2024 14:11
@fmeum fmeum merged commit 2836c49 into bazelbuild:main Apr 8, 2024
9 checks passed
@jpsim jpsim deleted the add-yams-5.1.0 branch April 8, 2024 14:17
@jpsim
Copy link
Contributor Author

jpsim commented Apr 8, 2024

Thanks @fmeum and @brentleyjones !

aiuto pushed a commit to aiuto/bazel-central-registry that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants