Add gonzojive_protobuf_javascript module.#2853
Merged
meteorcloudy merged 12 commits intobazelbuild:mainfrom Sep 30, 2024
Merged
Add gonzojive_protobuf_javascript module.#2853meteorcloudy merged 12 commits intobazelbuild:mainfrom
meteorcloudy merged 12 commits intobazelbuild:mainfrom
Conversation
…' into protobuf_javascript_gonzojive
Member
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (protobuf_javascript_esm) have been updated in this PR. Please review the changes. |
Member
|
Maybe |
Contributor
|
Following other examples in the registry, |
Member
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (gonzojive_protobuf_javascript) have been updated in this PR. Please review the changes. |
Contributor
Author
|
Done. |
Wyverald
added
the
presubmit-auto-run
Wyverald
changed the title
Member
|
please fix check failures. |
```
generated_message_tctable_gen.h:99:42: error: 'google::protobuf::internal::TailCallTableInfo::FieldEntryInfo::utf8_check_mode' is too small to hold all values of 'enum class google::protobuf::internal::cpp::Utf8CheckMode' [-Werror]
cpp::Utf8CheckMode utf8_check_mode : 8;
```
Contributor
Author
|
I suspect it will work now. I removed debian10 due to a C++ error in protobuf that I'm not sure how to resolve. |
meteorcloudy
approved these changes
Sep 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checked with
python3 tools/bcr_validation.py --check=protobuf_javascript_esm.The module in question is my fork of the protobuf-javascript repo. The changes in the fork are unlikely to be accepted upstream (see protocolbuffers/protobuf-javascript#156).