[email protected]

[UebelAndre]

closes #3926

[bazel-io]

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (verilator) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

[UebelAndre]

@bazel-io skip_check unstable_url

[UebelAndre]

FYI @hzeller

[hzeller]

Nice!
I think @QuantamHD might be interested to have a look.

[UebelAndre]

This is impacted by:

• Fixed incompatibility issues failing BCR dependents jmillikin/rules_flex#13
• Fixed incompatibility issues failing BCR dependents jmillikin/rules_m4#18
• Fixed incompatibility issues failing BCR dependents jmillikin/rules_bison#18

[meteorcloudy]

@UebelAndre Thanks for all the fixes, to unblock this, you can comment @bazel-io skip_check incompatible_flags in this PR. See https://github.com/bazelbuild/bazel-central-registry/blob/main/docs/README.md#testing-incompatible-flags

[UebelAndre]

For me this only blocks a migration to bzlmod but I'd rather not have to keep local patches for the issues identified in #4341 (comment). I'd rather wait for @jmillikin to review to avoid churn making *.bcr.* patches here. Hopefully that doesn't take more than a day or two.

[UebelAndre]

@bazel-io skip_check incompatible_flags

@meteorcloudy this build actually fails for a different reason and actually conforms to all incompatibility flags. FIY:

(15:31:26) ERROR: /Users/buildkite/builds/bk-macos-arm64-6c7i/bazel-org-repo-root/output/verilator-5.034/ci/docker/run/hooks/BUILD:10:8: syntax error at 'build': expected newline
(15:31:26) ERROR: /Users/buildkite/builds/bk-macos-arm64-6c7i/bazel-org-repo-root/output/verilator-5.034/ci/docker/run/hooks/BUILD:10:40: invalid character: '$'
(15:31:26) ERROR: /Users/buildkite/builds/bk-macos-arm64-6c7i/bazel-org-repo-root/output/verilator-5.034/ci/docker/run/hooks/BUILD:10:60: invalid character: '$'
(15:31:26) ERROR: /Users/buildkite/builds/bk-macos-arm64-6c7i/bazel-org-repo-root/output/verilator-5.034/ci/docker/run/hooks/BUILD:10:80: invalid character: '$'
(15:31:26) ERROR: package contains errors: ci/docker/run/hooks
(15:31:28) ERROR: package contains errors: ci/docker/run/hooks: syntax error at 'build': expected newline
(15:31:28) WARNING: Target pattern parsing failed.
(15:31:28) ERROR: Skipping '//...': Error evaluating '//...': error loading package 'ci/docker/run/hooks': Package 'ci/docker/run/hooks' contains errors
(15:31:28) ERROR: Error evaluating '//...': error loading package 'ci/docker/run/hooks': Package 'ci/docker/run/hooks' contains errors

[meteorcloudy]

Hmm, looks like the BUILD file was somehow changed? Let's retry the build first.

[meteorcloudy]

I think this might be a weird bug in Bazel, I'm able to reproduce this locally by running bazel build twice.

[meteorcloudy]

Although the content of

$ cat ci/docker/run/hooks/BUILD
#!/bin/bash
# DESCRIPTION: Docker hub hook to pass SOURCE_COMMIT
#
# Copyright 2020 by Stefan Wallentowitz. This program is free software; you
# can redistribute it and/or modify it under the terms of either the GNU
# Lesser General Public License Version 3 or the Perl Artistic License
# Version 2.0.
# SPDX-License-Identifier: LGPL-3.0-only OR Artistic-2.0

docker build --build-arg SOURCE_COMMIT=${SOURCE_COMMIT} -f $DOCKERFILE_PATH -t $IMAGE_NAME .

is indeed confusing to bazel

[meteorcloudy]

Let's wait for other reviewers to take a look then I can help merge it.

[UebelAndre]

@meteorcloudy looks like windows workers are also running into a similar issue.

[meteorcloudy]

https://github.com/verilator/verilator/blob/master/ci/docker/run/hooks/build is confusing Bazel.

@UebelAndre Let's add a .bazelignore file at the source root containing ci

$ cat .bazelignore
ci

[meteorcloudy]

@UebelAndre Looks like windows doesn't work, feel free to remove

[UebelAndre]

@meteorcloudy this PR is good to go on my end. I leave the rest to you