Skip to content

[email protected] #4362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[email protected] #4362

wants to merge 3 commits into from
+72 −5

Conversation

Vertexwahn
Copy link
Contributor

@bazel-io
Copy link
Member

Hello @wep21, modules you maintain (boost.config) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@Vertexwahn
Copy link
Contributor Author

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Apr 18, 2025
@Vertexwahn @wep21
Update source.json
849d3b9 
Co-authored-by: Daisuke Nishimatsu <[email protected]>
@wep21
Copy link
Contributor

wep21 commented Apr 20, 2025

@fmeum @meteorcloudy please add skip compatibility level check label.

@fmeum
Copy link
Contributor

fmeum commented Apr 20, 2025

Happy to do so, but now that 7.6 and 8.2 are out, you could switch over to the potentially more user-friendly approach of using "nodep" deps: You would need to add a single otherwise empty boost "meta" module that has bazel_deps on all the other boost modules at the same version, but with repo_name = None. Then all individual modules have a regular dependency on this boost module, which results in a cycle that forces everything to the same version.

@fmeum fmeum added the skip-compatibility-level-check Skip the compatibility_level check for MODULE.bazel label Apr 20, 2025
@Wyverald Wyverald added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wep21 wep21 wep21 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-compatibility-level-check Skip the compatibility_level check for MODULE.bazel skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Vertexwahn @bazel-io @wep21 @fmeum @Wyverald