Skip to content

Publish [email protected] #4424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aspect-marvin
Copy link
Contributor

@bazel-io
Copy link
Member

Hello @jbedard, modules you maintain (aspect_rules_webpack) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Copy link
Member

@bazel-io bazel-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @bazelbuild/bcr-maintainers, all modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Apr 25, 2025
@keith keith enabled auto-merge (squash) April 30, 2025 16:21
@keith
Copy link
Member

keith commented Apr 30, 2025

real download failure here

@jbedard
Copy link
Contributor

jbedard commented Apr 30, 2025

That is a windows bug in bazel-lib that will need it's own fix (and rules_webpack should update the minimum version). Can this still be merged?

@keith
Copy link
Member

keith commented Apr 30, 2025

only if we disable windows CI, otherwise we should bump those deps versions probably?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants