Skip to content

Publish [email protected] #4552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2025
Merged

Publish [email protected] #4552

merged 3 commits into from
May 9, 2025

Conversation

aspect-marvin
Copy link
Contributor

@bazel-io
Copy link
Member

bazel-io commented May 9, 2025

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (rules_scala) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@alexeagle
Copy link
Contributor

@bazel-io skip_check incompatible_flags

@bazel-io bazel-io added the skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit label May 9, 2025
@alexeagle
Copy link
Contributor

alexeagle commented May 9, 2025 •
edited
Loading

This is ready to merge - it's only a draft because of a setting on rules_scala that has been later updated.

I'm adding notes about this release here: bazel-contrib/rules_scala#1482 (comment)

@alexeagle
Copy link
Contributor

FYI @simuons @mbland

@mbland
Copy link
Contributor

mbland commented May 9, 2025

BTW, examples/crossbuild/protobuf.patch is a symlink to ../../protoc/0001-protobuf-19679-rm-protoc-dep.patch. Are symlinks not enabled on the BCR Windows builds?

@alexeagle
Copy link
Contributor

See discussion about symlinks #4192

@mbland
Copy link
Contributor

mbland commented May 9, 2025

See discussion about symlinks #4192

That seems to pertain to symlinks for MODULE.bazel and other BCR artifacts. In this case, the symlinked file is in the nested test module we're using for a smoke test. All other builds pass, just Windows failed.

But I suppose the answer is that no, symlinks aren't enabled on the BCR Windows CI machines. Makes sense.

I also wonder, since the BCR Windows CI build of 'protobuf' v30.2 passes, if we could set --noincompatible_enable_proto_toolchain_resolution for that build, or even on all the builds. It seems like MSYS2 might've pushed the 'protoc' compile over the edge, so maybe Windows builds would work when recompiling protoc here.

Either way, it looks like everything's in order to actually publish the module. @alexeagle Do you want to merge this now?

@alexeagle
Copy link
Contributor

I don't have permission to merge, @fmeum or @meteorcloudy are likely to get here first :)

mbland added a commit to EngFlow/example that referenced this pull request May 9, 2025
@mbland
Use rules_scala v7.0.0 from GitHub, bump versions
d1b752e 
Using the `rules_scala` Bazel module, upgrading from v6.6.0 to v7.0.0,
is the most significant change here. Will update `MODULE.bazel` to use
`rules_scala` from the Bazel Central Registry after
bazelbuild/bazel-central-registry#4552 lands.

Lots of other version bumps:

- Bazel: 8.2.0 => 8.2.1
- Go: 1.22.5 => 1.24.3
- `apple_support`: 1.15.1 => 1.22.0
- `aspect_rules_ts`: 2.4.2 => 3.5.3
- `com.google.oauth-client:google-oauth-client`: 1.36.0 => 1.39.0
- `commons-cli:commons-cli`: 1.8.0 => 1.9.0
- `engflowapis-java`: 2025.01.17-13.50.20 => 2025.03.14-12.58.52
- `gazelle`: 0.37.0 => 0.43.0
- `googleapis`: 0.0.0-20240326-1c8d509c5 => 0.0.0-20241220-5e258e33.bcr.1
- `grpc-java`: 1.64.0 => 1.71.0
- `io.netty:netty-handler`: 4.1.111.Final => 4.1.121.Final
- `protobuf`: v23.1 => v30.2
- `rules_cc`: 0.0.9 => 0.1.1
- `rules_dotnet`: 0.18.1 => 0.18.2
- `rules_go`: 0.48.1 => 0.54.0
- `rules_java`: 7.9.1 => 8.11.0
- `rules_jvm_external`: 6.2 => 6.7
- `rules_kotlin`: 1.9.6 => 2.1.4
- `rules_perl`: 0.2.0 => 0.4.1
- `rules_proto_grpc`: 5.0.0-alpha2 => 5.0.1
- `rules_proto`: 6.0.2 => 7.1.0
- `rules_python`: 1.0.0 => 1.4.1
- `rules_swift`: 1.18.0 => 2.8.2

Other changes:

- Adds `scala/0001-protobuf-19679-rm-protoc-dep.patch` and adds `common
  --incompatible_enable_proto_toolchain_resolution` to `.bazelrc`. This
  enables the precompiled `protoc` toolchain from `rules_scala`,
  `@rules_scala_protoc_toolchains`.

- Updates C++ compiler flags in `.bazelrc` to `-std=c++17` to build
  `protobuf` v30.2 remotely on an EngFlow cluster.

- Updates `README.md` to include the EngFlow credential helper in
  `.bazelrc.user`, and to specify `--config=engflow` as needed.

- Updates `@rules_scala` and `@rules_swift` references in `BUILD` files.

- Ran `bazel mod tidy` to standardize the formatting of `MODULE.bazel`.
@mbland mbland mentioned this pull request May 9, 2025
Merged
mbland added a commit to EngFlow/example that referenced this pull request May 9, 2025
@mbland
Use rules_scala v7.0.0 from GitHub, bump versions (#389)
fb37786 
Using the `rules_scala` Bazel module, upgrading from v6.6.0 to v7.0.0,
is the most significant change here. Will update `MODULE.bazel` to use
`rules_scala` from the Bazel Central Registry after
bazelbuild/bazel-central-registry#4552 lands.

Lots of other version bumps:

- Bazel: 8.2.0 => 8.2.1
- Go: 1.22.5 => 1.24.3
- `apple_support`: 1.15.1 => 1.22.0
- `aspect_rules_ts`: 2.4.2 => 3.5.3
- `com.google.oauth-client:google-oauth-client`: 1.36.0 => 1.39.0
- `commons-cli:commons-cli`: 1.8.0 => 1.9.0
- `engflowapis-java`: 2025.01.17-13.50.20 => 2025.03.14-12.58.52
- `gazelle`: 0.37.0 => 0.43.0
- `googleapis`: 0.0.0-20240326-1c8d509c5 =>
0.0.0-20241220-5e258e33.bcr.1
- `grpc-java`: 1.64.0 => 1.71.0
- `io.netty:netty-handler`: 4.1.111.Final => 4.1.121.Final
- `protobuf`: v23.1 => v30.2
- `rules_cc`: 0.0.9 => 0.1.1
- `rules_dotnet`: 0.18.1 => 0.18.2
- `rules_go`: 0.48.1 => 0.54.0
- `rules_java`: 7.9.1 => 8.11.0
- `rules_jvm_external`: 6.2 => 6.7
- `rules_kotlin`: 1.9.6 => 2.1.4
- `rules_perl`: 0.2.0 => 0.4.1
- `rules_proto_grpc`: 5.0.0-alpha2 => 5.0.1
- `rules_proto`: 6.0.2 => 7.1.0
- `rules_python`: 1.0.0 => 1.4.1
- `rules_swift`: 1.18.0 => 2.8.2

Other changes:

- Adds `scala/0001-protobuf-19679-rm-protoc-dep.patch` and adds `common
--incompatible_enable_proto_toolchain_resolution` to `.bazelrc`. This
enables the precompiled `protoc` toolchain from `rules_scala`,
`@rules_scala_protoc_toolchains`.

- Updates C++ compiler flags in `.bazelrc` to `-std=c++17` to build
`protobuf` v30.2 remotely on an EngFlow cluster.

- Updates `README.md` to include the EngFlow credential helper in
`.bazelrc.user`, and to specify `--config=engflow` as needed.

- Removed `repo_name` from every `bazel_dep`.

- Updated former `repo_name` references in `BUILD` files.

- Ran `bazel mod tidy` to standardize the formatting of `MODULE.bazel`.
@mbland mbland mentioned this pull request May 9, 2025
Closed
@Wyverald Wyverald marked this pull request as ready for review May 9, 2025 21:22
@Wyverald Wyverald added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label May 9, 2025
Wyverald
Wyverald approved these changes May 9, 2025
View reviewed changes
Copy link
Member

@Wyverald Wyverald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!

@Wyverald Wyverald enabled auto-merge (squash) May 9, 2025 21:24
@Wyverald Wyverald merged commit 1808ec8 into bazelbuild:main May 9, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyverald Wyverald Wyverald approved these changes

Assignees
No one assigned
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aspect-marvin @bazel-io @alexeagle @mbland @Wyverald