[email protected]

[grpc-bot]

Release: https://github.com/grpc/grpc/releases/tag/v1.78.0-pre1

Automated by Publish to BCR

[bazel-io]

Hello @pawbhard, @rishesh007, @markdroth, @sergiitk, @yuanweiz, @asheshvidyut, @sreenithi, modules you maintain (grpc) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

[gemini-code-assist]

Code Review

This pull request introduces version 1.78.0-pre1 for the grpc module. The changes are generally well-structured for a new module version in the Bazel Central Registry. However, there are a couple of areas that need improvement. The MODULE.bazel file uses an http_archive for a Python dependency, which goes against bzlmod best practices and should be managed through pip. Additionally, the presubmit.yml configuration is missing a build target for the Windows platform, leading to incomplete test coverage. Addressing these points will improve the maintainability and robustness of this module.

[gemini-code-assist]

The use of http_archive to fetch typing_extensions is discouraged in bzlmod. This creates a private dependency for the grpc module, which can lead to issues for downstream users if any part of grpc's public API relies on it. Python dependencies should be managed via pip.parse from rules_python to ensure they are properly integrated into the Bazel dependency graph. Please consider adding typing_extensions to your requirements.bazel.lock file and removing this http_archive declaration.

[gemini-code-assist]

The verify_targets_on_windows task is missing the @grpc//examples/protos/... build target, which is present in the other verify_targets tasks. For consistency and to ensure full build coverage across all platforms, this target should also be included for Windows if it's expected to build there.

      - "@grpc//:grpcpp_orca_service"
      - "@grpc//examples/protos/..."

[sergiitk]

@bazel-io skip_check unstable_url

[sergiitk]

@bazel-io skip_check incompatible_flags