Conversation
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (proxy-wasm-rust-sdk) have been updated in this PR. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the new module proxy-wasm-rust-sdk at version 0.2.4-251205-5283e57. My review has identified several critical issues that prevent this PR from being merged. The metadata.json file contains an incorrect version, and the MODULE.bazel file references local files using absolute paths, which will fail in the BCR. These files must be included in the PR and referenced correctly. Additionally, as this is a new module, the maintainers and repository fields require manual review by @bazelbuild/bcr-maintainers, as per the repository style guide (line 62).
phlax
force-pushed
the
proxy-wasm-rust-sdk
branch
from
8389462 to
9960224
Compare
|
cc @leonm1 kinda needs the patched rules_rust to be in bcr first |
phlax
force-pushed
the
proxy-wasm-rust-sdk
branch
7 times, most recently
from
c34db64 to
4741898
Compare
|
@bazel-io skip_check unstable_url |
bazel-io
added
the
skip-url-stability-check
| platform: ${{ unix_platform }} | ||
| bazel: ${{ bazel }} | ||
| # remove this (and associated patch) if/when https://github.com/bazelbuild/bazel-central-registry/pull/7232 lands | ||
| build_flags: |
There was a problem hiding this comment.
this needs to be removed once the pr is not wip
Signed-off-by: Ryan Northey <[email protected]>
phlax
force-pushed
the
proxy-wasm-rust-sdk
branch
from
4741898 to
1866f58
Compare
|
This PR has been automatically marked as stale because it has not had any activity for 30 days. It will be closed in 14 days if no further activity occurs. Please comment on this PR to keep it open, or ask |
github-actions
bot
added
the
stale
|
This PR has been closed due to inactivity. |
2 participants
No description provided.