Update protobuf to 29.3 #25248
Open
Update protobuf to 29.3 #25248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
sgowroji
added
the
team-ExternalDeps
github-actions
bot
removed
the
awaiting-review
github-actions
bot
added
the
awaiting-review
|
the test logs are in the "artifacts" tab of the failed test job. Your failure is probably because you need to update the default lockfile ( |
Versions 29.0 and below pollute the default maven repo name with protobuf's dependencies. Update to a version that doesn't.
|
The change moves some jar artifacts from a repository (maven) to another (protobuf_maven) and there are several errors related to downloading these artifacts. I've noticed that the command that is failing has this flag (which I am unfamiliar with): I am guessing it's probably related to that. |
Java artifacts used by protobuf are now under repository protobuf_maven instead of maven. Pass along this information.
joca-bt
commented
Feb 13, 2025
| @@ -202,11 +202,19 @@ write_file( | |||
| content = [get_canonical_repo_name("@maven")], | |||
| ) | |||
|
|
|||
| _PROTOBUF_MAVEN_CANONICAL_REPO_NAME = "rules_jvm_external++maven+protobuf_maven" | |||
|
|
|||
| write_file( | |||
There was a problem hiding this comment.
@Wyverald I'm not particularly happy with the result, maybe you can advise?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions 29.0 and below pollute the default maven repo name with protobuf's dependencies. Update to a version that doesn't.