Clean up JNI initialization #25340
Open
Clean up JNI initialization #25340
+79
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
Instead of relying on `getpid` to be implemented by a native method, explicitly invoke an empty native function to force linking at a time convenient for error reporting. Also make sure that the extracted JNI library is cleaned up on Windows.
fmeum
force-pushed
the
clean-up-process-handle
branch
from
c0d809f to
21a7836
Compare
fmeum
force-pushed
the
clean-up-process-handle
branch
from
21a7836 to
cc6a4ca
Compare
iancha1992
added
the
team-Remote-Exec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on
getpidto be implemented by a native method, explicitly invoke an empty native function to force linking at a time convenient for error reporting.Also make sure that the extracted JNI library is cleaned up on Windows.