Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently use \n as line terminator in build and stdout output #25341

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Consistently use \n as line terminator in build and stdout output #25341

wants to merge 3 commits into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Feb 20, 2025 •
edited
Loading

Keep system-dependent line terminators in console output. It's probably okay to switch to \n there as well, but as unstructured output it doesn't really matter for cross-platform reproducibility.

@fmeum fmeum requested review from a team as code owners February 20, 2025 13:32
@fmeum fmeum requested review from katre and removed request for a team February 20, 2025 13:32
@fmeum fmeum marked this pull request as draft February 20, 2025 13:32
@github-actions github-actions bot added team-Performance Issues for Performance teams team-Configurability platforms, toolchains, cquery, select(), config transitions team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. team-Local-Exec Issues and PRs for the Execution (Local) team team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Feb 20, 2025
@fmeum fmeum changed the title Consistently use '\n' as the line terminator in build and stdout output Consistently use \n as the line terminator in build and stdout output Feb 20, 2025
@fmeum fmeum changed the title Consistently use \n as the line terminator in build and stdout output Consistently use \n as line terminator in build and stdout output Feb 20, 2025
@fmeum fmeum removed request for a team and katre February 20, 2025 13:47
@fmeum fmeum force-pushed the consistent-line-endings branch 4 times, most recently from 9e1e0ed to 534c939 Compare February 20, 2025 15:00
@fmeum
Consistently use '\n' as the line terminator in build and stdout ou…
2d063db 
…tput

Keep system-dependent line terminators in stderr output.
@fmeum fmeum force-pushed the consistent-line-endings branch from 534c939 to 2d063db Compare February 20, 2025 15:12
@fmeum fmeum force-pushed the consistent-line-endings branch from 7ae8835 to b9e4058 Compare February 20, 2025 19:47
@fmeum fmeum marked this pull request as ready for review February 20, 2025 20:07
@fmeum fmeum requested a review from tjgq February 20, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjgq tjgq Awaiting requested review from tjgq

Assignees
No one assigned
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Configurability platforms, toolchains, cquery, select(), config transitions team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. team-Local-Exec Issues and PRs for the Execution (Local) team team-Performance Issues for Performance teams team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fmeum