Don't swallow runfiles of srcs in data runfiles of filegroup
#25365
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `data_runfiles` of a `filegroup` should contain the `data_runfiles` of all deps in `srcs`, plus the `data_runfiles` of all deps in `data`. Previously, they didn't contain the former.
|
I'm not entirely sure whether the correct behavior would be to merge in the |
github-actions
bot
added
the
awaiting-review
|
Testing in downstream: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/4493 |
|
Thanks, the run looks good, all failures are caused by known issues. |
iancha1992
added
the
team-OSS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
data_runfilesof afilegroupshould contain thedata_runfilesof all deps insrcs, plus thedata_runfilesof all deps indata. Previously, they didn't contain the former.Related to #25329 (comment)