Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.2.0] Manual merge of --experimental_propagate_custom_flag support. #25371

Open
wants to merge 1 commit into
base: release-8.2.0
Choose a base branch
from

Conversation

gregestren
Copy link
Contributor

@gregestren gregestren commented Feb 25, 2025

Made this PR because auto-merging from #25271. failed with conflicts. That's because both of the below commits need to be merged.

Merges:

Result:

  • support //foo/... syntax
  • correctly handle label conversion

Fixes #25271.

Merges:

 - bazelbuild@324c900
 - bazelbuild@e1d5e86

Result:

 - support `//foo/...` syntax
 - correctly handle label conversion

Fixes bazelbuild#25271.
@gregestren gregestren requested a review from a team as a code owner February 25, 2025 02:19
@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-review PR is awaiting review from an assigned reviewer labels Feb 25, 2025
@gregestren gregestren requested review from katre and iancha1992 and removed request for a team February 25, 2025 02:22
@katre
Copy link
Member

katre commented Feb 25, 2025

Looks like the test failure is a real issue, please investigate.

@gregestren
Copy link
Contributor Author

Looks like the test failure is a real issue, please investigate.

Yeah. Didn't reproduce locally on first try. But I'll figure it out.

@iancha1992 iancha1992 enabled auto-merge February 26, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review PR is awaiting review from an assigned reviewer team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants