fix(downloader): handle invalid regex in downloader config #25380
+14
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses Issue #20832, where an invalid regex in the
--experimental_downloader_config
file caused Bazel to crash silently without an error message.Changes Introduced:
PatternSyntaxException
when compiling regex patterns inUrlRewriterConfig.java
.UrlRewriterParseException
with a clear error message instead of crashing.Before the Fix:
downloader.cfg
(e.g.,rewrite (.*\maven.org/.*) http://example.com/mirror/$1
) caused Bazel to crash with error code 37, but no explanation was given.After the Fix:
Testing & Verification:
downloader.cfg
.Impact & Notes:
Related Issue:
Closes #20832