Use /usr/bin/env bash shebang in shell scripts #25934
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`#!/bin/bash` is less portable than `#!/usr/bin/env bash` because it can
pick up Bash from more locations and is also customizable via `PATH`.
Some scripts were already using `#!/usr/bin/env bash` but not all.
Note: only touching plain shell script files in this PR, script
files that are generated in rules are also subject to same
portability concern but change there may need extra attention
boltzmannrain
requested review from
a team,
lberki,
allevato,
DavidGoldman,
dmaclach and
thomasvl
as code owners
github-actions
bot
added
team-Rules-Java
meisterT
added
team-OSS
meteorcloudy
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#!/usr/bin/env bashis more portable than#!/bin/bashbecause it can pick up Bash from more locations and is also customizable viaPATH. Some scripts were already using#!/usr/bin/env bashbut not all.Note: only touching plain shell script files in this PR, script
files that are generated in rules are also subject to same
portability concern but change there may need extra attention
Edge cases:
/bin/bash -eu -> /usr/bin/env bash; set -eusrc/test/shell/bazel/bazel_wrapper_test.shsets up mockbin/location, addingbashthere to be picked up is needed, for now not doing that and excludingscripts/packages/bazel.shfrom changes