http_jar repositories now load java_import from rules_java #25951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the Starlarkification of the Java rules, the BUILD file generated by http_jar() should no longer assume that java_import is available as a Bazel builtin.
dws
force-pushed
the
http_jar-loads-java_import
branch
from
1ceafb2 to
1c17b87
Compare
fmeum
reviewed
Apr 26, 2025
tools/build_defs/repo/http.bzl
Outdated
| @@ -191,6 +191,8 @@ def _http_file_impl(ctx): | |||
| return _update_integrity_attr(ctx, _http_file_attrs, download_info) | |||
|
|
|||
| _HTTP_JAR_BUILD = """\ | |||
| load("@rules_java//java:java_import.bzl", "java_import") | |||
There was a problem hiding this comment.
Could you load http_jar from rules_java instead? Then all this code can be deleted from bazel_tools.
This reverts commit 1c17b87.
This reverts commit 1c45bc5. It appears that bazelbuild#20722 is resolved, so it should be safe to once again avoid relying on the native rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the Starlarkification of the Java rules, the BUILD file generated by http_jar() should no longer assume that java_import is available as a Bazel builtin.