Skip to content

http_jar repositories now load java_import from rules_java #25951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dws
Copy link
Contributor

@dws dws commented Apr 26, 2025

Given the Starlarkification of the Java rules, the BUILD file generated by http_jar() should no longer assume that java_import is available as a Bazel builtin.

Given the Starlarkification of the Java rules, the BUILD file
generated by http_jar() should no longer assume that java_import
is available as a Bazel builtin.
@dws dws force-pushed the http_jar-loads-java_import branch from 1ceafb2 to 1c17b87 Compare April 26, 2025 04:49
@@ -191,6 +191,8 @@ def _http_file_impl(ctx):
return _update_integrity_attr(ctx, _http_file_attrs, download_info)

_HTTP_JAR_BUILD = """\
load("@rules_java//java:java_import.bzl", "java_import")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you load http_jar from rules_java instead? Then all this code can be deleted from bazel_tools.

dws added 2 commits April 26, 2025 02:06
This reverts commit 1c45bc5.

It appears that bazelbuild#20722 is resolved, so it should be safe to
once again avoid relying on the native rules.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants