Avoid two stats for non-directory symlinks created remotely #25986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team-Remote-Exec
fmeum
commented
May 2, 2025
| && symlink.path().isDirectory(Symlinks.NOFOLLOW)) { | ||
| // If a directory output is being materialized as a symlink, creating the symlink fails as we | ||
| // must first delete the preexisting empty directory. Since this is rare (and in the future | ||
| // BwoB may no longer eagerly create these directories), we don't delete the directory |
There was a problem hiding this comment.
This refers to #25976. I can update the comment depending on which PR is merged first.
There was a problem hiding this comment.
Let's get #25976 merged first (it needs a rebase).
There was a problem hiding this comment.
Approving since #25976 can't yet be merged.
tjgq
approved these changes
May 22, 2025
tjgq
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
|
Can we cherry-pick this into 8.x/7.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.