Skip to content

Add tag name to error messages #26001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented May 5, 2025

Before this change, the error only included the location of the tag.

Before this change, the error only included the location of the tag.
@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels May 5, 2025
@fmeum
Copy link
Collaborator Author

fmeum commented May 5, 2025

What do you think, should we also add the extension ID to the error message?

@Wyverald
Copy link
Member

Wyverald commented May 5, 2025

Does it matter much? Shouldn't the location tell you what tag it was?

@fmeum
Copy link
Collaborator Author

fmeum commented May 5, 2025

Does it matter much? Shouldn't the location tell you what tag it was?

It does, but since this is an error without a Starlark stacktrace, it basically requires you to open up that file at that line before you can make sense of the error.

I guess this could be compared to a compiler error telling you that a parameter type is wrong, but not telling you the name of the function.

@fmeum fmeum force-pushed the print-tag-class branch from 210fa7d to 6bcf449 Compare May 5, 2025 15:04
@fmeum fmeum force-pushed the print-tag-class branch from 6bcf449 to c48d448 Compare May 5, 2025 15:58
@fmeum
Copy link
Collaborator Author

fmeum commented May 5, 2025

CI is green now

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels May 13, 2025
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants