Skip to content

Fix the docs for using Clang on Windows #26003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

ivan444
Copy link
Contributor

@ivan444 ivan444 commented May 5, 2025

Closes #26002

Remove the step that's changing the MODULE.bazel file. It no longer works (Bazel errors out) and it's not needed (Bazel with Clang works without it).

@github-actions github-actions bot added team-Documentation Documentation improvements that cannot be directly linked to other team labels awaiting-review PR is awaiting review from an assigned reviewer labels May 5, 2025
@iancha1992 iancha1992 added the team-Rules-CPP Issues for C++ rules label May 6, 2025
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels May 16, 2025
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label May 17, 2025
fmeum pushed a commit to fmeum/bazel that referenced this pull request May 20, 2025
Closes bazelbuild#26002

Remove the step that's changing the MODULE.bazel file. It no longer works (Bazel errors out) and it's not needed (Bazel with Clang works without it).

Closes bazelbuild#26003.

PiperOrigin-RevId: 759995454
Change-Id: I7a4ccb6dce215516433c4a6a9aaf9e62f5f68326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Documentation Documentation improvements that cannot be directly linked to other team labels team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instructions for setting up Bazel with Clang on Windows are broken
3 participants