Replace --define=EXECUTOR=remote with toolchains and selects
#26019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
changed the title
--define=EXECUTOR=remote with toolchains and select--define=EXECUTOR=remote with toolchains and selects
fmeum
force-pushed
the
19587-launcher-toolchain
branch
3 times, most recently
from
dcff9af to
fed82d4
Compare
github-actions
bot
added
team-Documentation
fmeum
added
the
team-ExternalDeps
meteorcloudy
approved these changes
May 8, 2025
There was a problem hiding this comment.
This is very smart, thanks!
/cc @pzembrod to take a look since this is affects C++ rules.
|
@bazel-io fork 8.3.0 |
|
The way launcher_maker is handled isn't quite correct. It probably needs to be depended on as a toolchain. I'll set this to draft for now. |
This allows for cross-platform builds to work seamlessly without a need to manually toggle between prebuilt and from source toolchains.
fmeum
force-pushed
the
19587-launcher-toolchain
branch
from
395a5e9 to
c682fca
Compare
|
@meteorcloudy I switched to a toolchain approach that rules_java, rules_python and rules_shell will be able to adopt via |
fmeum
force-pushed
the
19587-launcher-toolchain
branch
from
c682fca to
43947a5
Compare
|
Nice, is it possible to write a test to verify that with this approach, C++ toolchain dependency won't be propagated by depending on the launcher? |
|
I would like to add such a test (as a Starlark analysis test) to the individual rulesets that adopt the toolchain, where it fits better semantically by more generally verifying that cross-compilation works without a C++ toolchain. |
meteorcloudy
approved these changes
May 13, 2025
meteorcloudy
added
awaiting-PR-merge
pzembrod
approved these changes
May 14, 2025
github-actions
bot
removed
the
awaiting-PR-merge
hvadehra
pushed a commit
that referenced
this pull request
May 28, 2025
This allows for cross-platform builds to work seamlessly without a need to manually toggle between prebuilt and from source toolchains. As a positive side effect, this change also paves the way for dropping a dependency on an exec-configured C++ toolchain of Java and Python targets built for non-Windows platforms. Rulesets will need to migrate to using the launcher maker toolchain instead of the `launcher_maker` target. rules_shell wasn't affected by this as it already defined its own launcher toolchain. Work towards #19587 Closes #26019. PiperOrigin-RevId: 758697189 Change-Id: Ibfa272390056963ef35301614520fd38d018210e (cherry picked from commit e819495)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for cross-platform builds to work seamlessly without a need to manually toggle between prebuilt and from source toolchains.
As a positive side effect, this change also paves the way for dropping a dependency on an exec-configured C++ toolchain of Java and Python targets built for non-Windows platforms. Rulesets will need to migrate to using the launcher maker toolchain instead of the
launcher_makertarget. rules_shell wasn't affected by this as it already defined its own launcher toolchain.Work towards #19587