[8.4.0] Disallow output bases under GC-able directories #26596
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have had user's report spurious build failures due to the disk cache GC collecting files under the output base when output base and disk cache were set up at the same path. Closes bazelbuild#26138. PiperOrigin-RevId: 785412502 Change-Id: I44865ce44782a21a4cc15b61f0e0c9d4f13ea194
bazel-io
added
team-Remote-Exec
Member
|
@tjgq Could you please take a look at the failed tests? Thanks |
Contributor
|
@fmeum Are you able to take a look? Otherwise let's drop it from 8.4.0. |
tjgq
added
the
soft-release-blocker
Collaborator
|
I made the error message visible in #26716 and found it to complain about the output base not existing at the point we call |
auto-merge was automatically disabled
August 7, 2025 13:23
Pull request was closed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had user's report spurious build failures due to the disk cache GC collecting files under the output base when output base and disk cache were set up at the same path.
Closes #26138.
PiperOrigin-RevId: 785412502
Change-Id: I44865ce44782a21a4cc15b61f0e0c9d4f13ea194
Commit 216d333