Skip to content

Conversation

@keith
Copy link
Member

@keith keith commented Nov 21, 2025

This was flipped in bazel 7.0.0

@keith keith requested review from a team and lberki as code owners November 21, 2025 17:04
@keith keith requested review from gregestren and removed request for a team November 21, 2025 17:04
@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions team-Rules-Java Issues for Java rules team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Nov 21, 2025
This was flipped in bazel 7.0.0
@keith keith force-pushed the ks/delete-incompatible_allow_tags_propagation branch from 44ef778 to 54ffea0 Compare November 21, 2025 17:35
assert_contains_n "no-remote:" 1 output1
}

# Test a native test rule which has tags, that should be propagated (independent of flags)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment was outdated, likely just since starlarkification, this test was relying on the off behavior as well

@lberki
Copy link
Contributor

lberki commented Nov 24, 2025

@gregestren my understanding is that we can't flip this since it's still unflipped in google3, right? (b/285866916 for reference)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review PR is awaiting review from an assigned reviewer team-Configurability platforms, toolchains, cquery, select(), config transitions team-Rules-CPP Issues for C++ rules team-Rules-Java Issues for Java rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants