Skip to content

Conversation

@dabanki
Copy link

@dabanki dabanki commented Nov 25, 2025

This is a fork of #27498.

From the comments/open items on that PR, I've:

  1. Removed the tests that were called out as not needed.
  2. Added manual tag to focus_test to avoid pickup in larger runs until issue with --experimental_enable_skyfocus is resolved.
  3. Switched failing test cases from using from bazel_tools.tools.python.runfiles import runfiles to use from python.runfiles import runfiles

There are still a couple failing tests, looking for some guidance on if these can be removed/ignored:

test_source_file_does_not_override_standard_library FAILED: Expected regexp 'I am lib!' not found.

and

1) explicitInitPy_CanBeSelectivelyDisabled(com.google.devtools.build.lib.bazel.rules.python.BazelPyBinaryConfiguredTargetTest)
value of      : getEmptyFilenames()
unexpected (4): pkg/_foo.venv/lib/python3.11/__init__.py, pkg/_foo.venv/__init__.py, pkg/_foo.venv/lib/python3.11/site-packages/__init__.py, pkg/_foo.venv/lib/__init__.py
---
expected      : [pkg/__init__.py]
but was       : [pkg/_foo.venv/lib/python3.11/__init__.py, pkg/_foo.venv/__init__.py, pkg/_foo.venv/lib/python3.11/site-packages/__init__.py, pkg/__init__.py, pkg/_foo.venv/lib/__init__.py]
	at com.google.devtools.build.lib.bazel.rules.python.BazelPyBinaryConfiguredTargetTest.explicitInitPy_CanBeSelectivelyDisabled(BazelPyBinaryConfiguredTargetTest.java:235)
2) explicitInitPy_CanBeGloballyDisabled(com.google.devtools.build.lib.bazel.rules.python.BazelPyBinaryConfiguredTargetTest)
value of      : getEmptyFilenames()
unexpected (4): pkg/_foo.venv/lib/python3.11/__init__.py, pkg/_foo.venv/__init__.py, pkg/_foo.venv/lib/python3.11/site-packages/__init__.py, pkg/_foo.venv/lib/__init__.py
---
expected      : [pkg/__init__.py]
but was       : [pkg/_foo.venv/lib/python3.11/__init__.py, pkg/_foo.venv/__init__.py, pkg/_foo.venv/lib/python3.11/site-packages/__init__.py, pkg/__init__.py, pkg/_foo.venv/lib/__init__.py]
	at com.google.devtools.build.lib.bazel.rules.python.BazelPyBinaryConfiguredTargetTest.explicitInitPy_CanBeGloballyDisabled(BazelPyBinaryConfiguredTargetTest.java:250)

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Nov 25, 2025
@dabanki
Copy link
Author

dabanki commented Nov 25, 2025

@rickeylev Do the test modifications look okay to you? And do the failing test look important or can they also be removed?

cc @meteorcloudy

@rickeylev
Copy link
Contributor

lgtm

@dabanki
Copy link
Author

dabanki commented Nov 25, 2025

Thanks for taking a look! Do the failing tests look like legitimate issues to you?

@meteorcloudy
Copy link
Member

@bazel-io fork 9.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review PR is awaiting review from an assigned reviewer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants