[9.1.0] Fix cross-compilation to Windows with clang MinGW (https://github.com…#28832
Draft
iancha1992 wants to merge 2 commits intobazelbuild:release-9.1.0from
Draft
[9.1.0] Fix cross-compilation to Windows with clang MinGW (https://github.com…#28832iancha1992 wants to merge 2 commits intobazelbuild:release-9.1.0from
iancha1992 wants to merge 2 commits intobazelbuild:release-9.1.0from
Conversation
* Replace `select`s on flags for Windows with the appropriate compiler constraints. Also update `blake3`, which contains the same type of fix in its most recent version. * Ditch the `cmd.exe` implementation of `merge_licenses` that incorrectly matched on the target rather than the exec platform. Bash is already a requirement for Bazel at this point, so we might as well use it. * Drop the explicit C++17 standard flags since this is already the default standard in Bazel@HEAD. Get Bazel to build with `clang` (not `clang-cl`) on Windows and non-Windows platforms. No - [ ] I have added tests for the new use cases (if any). - [ ] I have updated the documentation (if applicable). RELNOTES: None Closes bazelbuild#28751. PiperOrigin-RevId: 874799593 Change-Id: Ia836e93d7307a30045c18e052228906c7be9ed92
iancha1992
added
team-Rules-CPP
Member
Author
|
@fmeum Could you please take a look at the error? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…//pull/28751)
selects on flags for Windows with the appropriate compiler constraints. Also updateblake3, which contains the same type of fix in its most recent version.cmd.exeimplementation ofmerge_licensesthat incorrectly matched on the target rather than the exec platform. Bash is already a requirement for Bazel at this point, so we might as well use it.Get Bazel to build with
clang(notclang-cl) on Windows and non-Windows platforms.No
RELNOTES: None
Closes #28751.
PiperOrigin-RevId: 874799593
Change-Id: Ia836e93d7307a30045c18e052228906c7be9ed92
Description
Motivation
Build API Changes
No
Checklist
Release Notes
RELNOTES: None
Commit 92f4d1a