Add exports_files in http_file BUILD.bazel#28859
Open
keith wants to merge 1 commit intobazelbuild:masterfrom
Open
Add exports_files in http_file BUILD.bazel#28859keith wants to merge 1 commit intobazelbuild:masterfrom
keith wants to merge 1 commit intobazelbuild:masterfrom
Conversation
github-actions
bot
added
the
awaiting-review
keith
force-pushed
the
ks/add-exports_files-in-http_file-build.bazel
branch
from
10b40bd to
7fabeda
Compare
fmeum
approved these changes
Mar 3, 2026
keith
force-pushed
the
ks/add-exports_files-in-http_file-build.bazel
branch
from
7fabeda to
2142bed
Compare
Without this, with `--incompatible_no_implicit_file_export` you are no longer allowed to directly depend on the downloaded file. Directly depending on the downloaded file is required if you want to use `executable = True`, and then make that file runnable with `bazel run` where that doesn't work if you attempt to run the `filegroup`. Exporting this file seems pretty safe since the user can also control its path.
keith
force-pushed
the
ks/add-exports_files-in-http_file-build.bazel
branch
from
2142bed to
43cf867
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, with
--incompatible_no_implicit_file_exportyou are nolonger allowed to directly depend on the downloaded file. Directly
depending on the downloaded file is required if you want to use
executable = True, and then make that file runnable withbazel runwhere that doesn't work if you attempt to run the
filegroup.Exporting this file seems pretty safe since the user can also control
its path.