docs: fix MDX parse errors from bare {…} expressions in concepts pages#28866
Draft
kapunahelewong wants to merge 1 commit intobazelbuild:masterfrom
Draft
docs: fix MDX parse errors from bare {…} expressions in concepts pages#28866kapunahelewong wants to merge 1 commit intobazelbuild:masterfrom
kapunahelewong wants to merge 1 commit intobazelbuild:masterfrom
Conversation
github-actions
bot
added
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix MDX parse errors in
docs/concepts/labels.mdx,docs/concepts/build-files.mdx, anddocs/concepts/dependencies.mdxcaused by bare{…}expressions that MDX tries to interpret as JSX.Changes:
{{ "<var>" }}/{{ "</var>" }}) with plain HTML<var>/</var>elements{: .external}link attribute frombuild-files.mdx{in<pre>code blocks independencies.mdxMotivation
These three files fail MDX parsing in the Bazel docs site (bazel-contrib/bazel-docs). The double-curly
{{ }}patterns are template syntax that need to be removed for the.md→.mdxmigration, and MDX's JSX parser rejects them as invalid expressions.Per conversation in bazel-contrib/bazel-docs#181
Build API Changes
No
Checklist
Release Notes
RELNOTES: None
Depends on: bazel-contrib/bazel-docs#206