[9.1.0] Only pass one InputMetadataProvider to ImportantOutputHandler.#28868
Open
iancha1992 wants to merge 1 commit intobazelbuild:release-9.1.0from
Open
[9.1.0] Only pass one InputMetadataProvider to ImportantOutputHandler.#28868iancha1992 wants to merge 1 commit intobazelbuild:release-9.1.0from
InputMetadataProvider to ImportantOutputHandler.#28868iancha1992 wants to merge 1 commit intobazelbuild:release-9.1.0from
Conversation
Blaze's `ImportantOutputHandler` only needs important output metadata because it processes top-level runfiles separately. Bazel's `RemoteImportantOutputHandler` needs (hidden) top-level runfiles trees in addition to important outputs. Instead of passing two metadata providers (important only and full), ask the `ImportantOutputHandler` which it needs. This is a step towards moving ownership tracking completely into `ActionRewindStrategy`. PiperOrigin-RevId: 877593911 Change-Id: I1ad1474a5cec900187ac0ae053e3275629d55b39
iancha1992
added
team-Remote-Exec
iancha1992
referenced
this pull request
Mar 3, 2026
Blaze's `ImportantOutputHandler` only needs important output metadata because it processes top-level runfiles separately. Bazel's `RemoteImportantOutputHandler` needs (hidden) top-level runfiles trees in addition to important outputs. Instead of passing two metadata providers (important only and full), ask the `ImportantOutputHandler` which it needs. This is a step towards moving ownership tracking completely into `ActionRewindStrategy`. PiperOrigin-RevId: 877593911 Change-Id: I1ad1474a5cec900187ac0ae053e3275629d55b39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blaze's
ImportantOutputHandleronly needs important output metadata because it processes top-level runfiles separately. Bazel'sRemoteImportantOutputHandlerneeds (hidden) top-level runfiles trees in addition to important outputs.Instead of passing two metadata providers (important only and full), ask the
ImportantOutputHandlerwhich it needs.This is a step towards moving ownership tracking completely into
ActionRewindStrategy.PiperOrigin-RevId: 877593911
Change-Id: I1ad1474a5cec900187ac0ae053e3275629d55b39
Description
Motivation
Build API Changes
No
Checklist
Release Notes
RELNOTES: None
Commit b005ba9